Fix card icon size + alignment #355
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview will be available once build job completes!
|
lamATnginx
force-pushed
the
card-icon-sizing
branch
from
43e3563 to
7f00cc5
Compare
lamATnginx
changed the title
TasoOneAsia
approved these changes
Aug 21, 2025
TasoOneAsia
reviewed
Aug 21, 2025
Comment on lines
+2165
to
+2166
| width: 1.5rem; | ||
| height: 1.5rem; |
There was a problem hiding this comment.
Not to tackle in this PR but this class is a little scary if we ever want to adjust sizing without affecting potential theme consumers.
It would probably be a good idea to variabilize this with variants (sm, md, lg) but lets cross that bridge when we get there.
There was a problem hiding this comment.
In the future, we can update the lucide partial and icon shortcode to accept new prop and add a data attribute.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Closes https://github.com/nginxinc/docs-platform/issues/618
Before:
After:
Checklist
Before creating a PR, run through this checklist and mark each as complete.
CONTRIBUTINGdocumentREADME.mdandCHANGELOG.md)